Skip to content

Fix typo in function name #5848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2021
Merged

Fix typo in function name #5848

merged 1 commit into from
Jun 18, 2021
+3 −3

Conversation

maya-r
Copy link
Contributor

@maya-r maya-r commented Jun 16, 2021

Release note:

NONE

@maya-r
Fix typo in function name.
648dff3 
Signed-off-by: Maya Rashish <mrashish@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Jun 16, 2021
@kubevirt-bot kubevirt-bot requested review from omeryahud and rmohr June 16, 2021 16:53
rmohr
rmohr approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member

@rmohr rmohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

pkg/virt-handler/vm.go
@@ -2374,7 +2374,7 @@ func (d *VirtualMachineController) vmUpdateHelperMigrationTarget(origVMI *v1.Vir
}

// give containerDisks some time to become ready before throwing errors on retries
info := d.getLauncherClinetInfo(vmi)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even knowing that there is a typo it is hard to see for me :D

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2021
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rmohr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2021
@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@maya-r
Copy link
Contributor Author

maya-r commented Jun 17, 2021

/test pull-kubevirt-e2e-k8s-1.20-rook-ceph

@maya-r maya-r mentioned this pull request Jun 17, 2021
Merged
@maya-r
Copy link
Contributor Author

maya-r commented Jun 17, 2021

/test pull-kubevirt-e2e-k8s-1.20-rook-ceph

1 similar comment
@maya-r
Copy link
Contributor Author

maya-r commented Jun 17, 2021

/test pull-kubevirt-e2e-k8s-1.20-rook-ceph

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit 9c03ac8 into kubevirt:master Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmohr rmohr

@omeryahud omeryahud

Assignees

@rmohr rmohr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maya-r @kubevirt-bot @kubevirt-commenter-bot @rmohr