Skip to content

docs, ADOPTERS: consistent capitalization #5836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2021
Merged

docs, ADOPTERS: consistent capitalization #5836

merged 1 commit into from
Jun 18, 2021
+20 −20

Conversation

dankenigsberg
Copy link
Member

Kubevirt -> KubeVirt. I find this inconsistency ugly and distracting.

Signed-off-by: Dan Kenigsberg danken@redhat.com

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 15, 2021
@kubevirt-bot kubevirt-bot requested review from EdDev and phoracek June 15, 2021 15:42
@dankenigsberg
Copy link
Member Author

/cc @mazzystr @dhiller

@kubevirt-bot kubevirt-bot requested review from dhiller and mazzystr June 15, 2021 15:42
@dankenigsberg dankenigsberg force-pushed the KubeVirt-capitalization branch from 94c49c8 to d4e23a2 Compare June 15, 2021 15:44
EdDev
EdDev approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@EdDev EdDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2021
enp0s3
enp0s3 approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@enp0s3 enp0s3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enp0s3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2021
@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2021
@dankenigsberg
docs, ADOPTERS: consistent capitalization
a5e23f1 
Kubevirt -> KubeVirt

Signed-off-by: Dan Kenigsberg <danken@redhat.com>
@dankenigsberg dankenigsberg force-pushed the KubeVirt-capitalization branch from d4e23a2 to a5e23f1 Compare June 16, 2021 20:17
@kubevirt-bot kubevirt-bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 16, 2021
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2021
@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit 8639a11 into kubevirt:master Jun 18, 2021
@dankenigsberg dankenigsberg deleted the KubeVirt-capitalization branch June 18, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhiller dhiller

@EdDev EdDev

@enp0s3 enp0s3

@phoracek phoracek

@mazzystr mazzystr

Assignees

@dhiller dhiller

@EdDev EdDev

@enp0s3 enp0s3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dankenigsberg @kubevirt-bot @kubevirt-commenter-bot @dhiller @EdDev @enp0s3