Skip to content

update to k8s 1.30 libs and controller-runtime 0.18.4 #3336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 14, 2024
Merged

update to k8s 1.30 libs and controller-runtime 0.18.4 #3336

merged 8 commits into from
Jul 14, 2024

Conversation

mhenriks
Copy link
Member

@mhenriks mhenriks commented Jul 5, 2024 •
edited by akalenyu
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1097

Special notes for your reviewer:

Release note:

k8s 1.30 libs and controller-runtime 0.18.4

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 5, 2024
mhenriks
mhenriks commented Jul 5, 2024
View reviewed changes
go.mod Outdated
)

replace kubevirt.io/controller-lifecycle-operator-sdk => github.com/mhenriks/controller-lifecycle-operator-sdk v0.0.7-0.20240702040137-0d244a67055d
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Until this is not pointing to my github

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2024
@mhenriks mhenriks mentioned this pull request Jul 5, 2024
Closed
@akalenyu
Copy link
Collaborator

akalenyu commented Jul 7, 2024

/retest

@akalenyu
Copy link
Collaborator

akalenyu commented Jul 7, 2024

@awels I think something's up with FOSSA here

mhenriks added 8 commits July 8, 2024 13:57
@mhenriks
make deps-update
37b5f1b 
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
@mhenriks
ReourceRequirements -> VolumeResourceRequirements
3468d22 
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
@mhenriks
fix calls to controller.Watch()
28daa6b 
controller-runtime changed the API!

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
@mhenriks
Fix errors with actual openshift/library-go lib
43dded1 
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
@mhenriks
make all works now and everything compiles
1b418f8 
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
@mhenriks
fix "make update-codegen" because generate_groups.sh deprecated
69fad00 
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
@mhenriks
run "make generate"
5f8c796 
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
@mhenriks
fix transfer unittest because of change to controller-runtime
Loading
Loading status checks…
51b552b 
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
@mhenriks
Copy link
Member Author

mhenriks commented Jul 8, 2024

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2024
@akalenyu
Copy link
Collaborator

akalenyu commented Jul 8, 2024

/approve
/cc @awels
FOSSA is lying I think

@kubevirt-bot kubevirt-bot requested a review from awels July 8, 2024 18:42
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2024
@awels
Copy link
Member

awels commented Jul 8, 2024 •
edited
Loading

Hmmm so it is complaining about a dependency in vendor/github.com/hashicorp/golang-lru being MPL 2.0. Which is not compatible with our licenses. It is being vendor-ed in through github.com/openshift/library-go
I think we should avoid anything hashicorp as much as possible.

@akalenyu
Copy link
Collaborator

akalenyu commented Jul 9, 2024

Hmmm so it is complaining about a depedency in vendor/github.com/hashicorp/golang-lru being MPL 2.0. Which is not compatible with our licenses. It is being vendor-ed in through github.com/openshift/library-go I think we should avoid anything hashicorp as much as possible.

right.. I see it's coming from their dep. on distribution/distribution in helpers we are not using:
openshift/library-go@01526ee
anyway, I wonder how other library-go consumers are not finding this problem

@mhenriks
Copy link
Member Author

mhenriks commented Jul 9, 2024

@awels golang-lru code is not in vendor directory so we are not actually directly or indirectly using it. Are there exceptions for this?

@awels
Copy link
Member

awels commented Jul 9, 2024

I can mark it as an exception indicating it is not being used at all. I wonder why it was flagged. You are right that it is not being vendored at all.

@awels
Copy link
Member

awels commented Jul 12, 2024

/test pull-containerized-data-importer-fossa

@awels
Copy link
Member

awels commented Jul 12, 2024

/test pull-containerized-data-importer-fossa

@awels
Copy link
Member

awels commented Jul 12, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2024
@akalenyu
Copy link
Collaborator

/test pull-containerized-data-importer-e2e-upg

@akalenyu
Copy link
Collaborator

I think this failure is about doing a rebind when pod is still running?
"cdi.kubevirt.io/storage.pod.phase": "Running",
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_containerized-data-importer/3336/pull-containerized-data-importer-e2e-upg/1811766743761162240

@akalenyu
Copy link
Collaborator

/test pull-containerized-data-importer-e2e-nfs
Error: failed get datavolume: test-dv, client rate limiter Wait returned an error: context deadline exceeded

@kubevirt-bot kubevirt-bot merged commit 5195176 into kubevirt:main Jul 14, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aglitke aglitke

@arnongilboa arnongilboa

@awels awels

Assignees

@awels awels

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using fork of openshift/library-go
4 participants
@mhenriks @akalenyu @kubevirt-bot @awels