consistent copyright notice #14531
Merged
consistent copyright notice #14531
+117
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note-none
Reviewer's Guide by SourceryThis pull request updates the copyright notices in various files across the repository to 'The KubeVirt Authors', replacing the previous 'Red Hat, Inc.' attribution. The change was implemented using No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
kubevirt-bot
requested review from
0xFelix,
acardace,
akalenyu,
alicefr,
alromeros,
avlitman,
awels,
Barakmor1,
brianmcarey,
dasionov,
EdDev,
enp0s3 and
fossedihelm
kubevirt-bot
added
the
sig/buildsystem
kubevirt-bot
requested review from
lyarwood,
machadovilaca,
nunnatsa,
orelmisan,
orenc1,
ormergi,
oshoval and
RamLavi
kubevirt-bot
added
sig/compute
sig/network
sig/observability
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @dankenigsberg - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a script to update the copyright headers automatically in the future.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Red Hat is willing to mark these files as copyrighted by the KubeVirt Authors. This is a follow-up of commit e36bb0b sed -i 's/\(20.., \)*20.. Red Hat, Inc./The KubeVirt Authors./' `git grep -l '20.. Red Hat, Inc.'|grep -v staging|grep -v vendor|grep -v kubevirtci` Signed-off-by: Dan Kenigsberg <danken@redhat.com>
dankenigsberg
force-pushed
the
consistent-copyright
branch
from
013826b to
11c4702
Compare
oshoval
approved these changes
Apr 21, 2025
There was a problem hiding this comment.
Thanks
basically this one is enough in this case i think, but it doesnt matter much
(of course the current is more robust the one below is just simpler to this case)
sed -i 's/20.. Red Hat, Inc./The KubeVirt Authors./' git grep -l '20.. Red Hat, Inc.'|grep -v staging|grep -v vendor
|
Pull requests that are marked with After that period the bot marks them with the label /label needs-approver-review |
kubevirt-bot
added
the
needs-approver-review
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enp0s3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
Required labels detected, running phase 2 presubmits: |
|
/remove-label needs-approver-review |
kubevirt-bot
removed
the
needs-approver-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Red Hat is willing to mark these files as copyrighted by the KubeVirt Authors. This is a follow-up of commit e36bb0b
sed -i 's/(20.., )*20.. Red Hat, Inc./The KubeVirt Authors./'
git grep -l '20.. Red Hat, Inc.'|grep -v staging|grep -v vendor/kind cleanup