-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Revert "W/A NFS server becoming unreachable mid run" #14362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/cc @akalenyu |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enp0s3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Required labels detected, running phase 2 presubmits: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - no issues with it. Can you just expand on why you think it is hurting more than helping?
Its a little too soon to say but it looks like we found a way of getting stable compute-migrations lanes again - #14354
I would prefer to take in #14354 before merging this just to limit the change see and to see if it helps.
/hold |
Just in case the nfs server pod ever restarts
That's not a bad idea, many tests there are quite resource-heavy, but I doubt that will solve the NFS issues we're seeing...
Absolutely, 1 test at a time is the way to go |
+1 - that would be a problem
I have 10 runs so far without hitting the nfs timeouts - at the current failure rate on main I would expect to hit it at least once or twice in 10 but you're right - proof is in the pudding - will have to see how it goes on main.
Cheers - thanks. But yeah we should look at removing this WA as soon as we can. |
See also kubevirt/kubevirtci#1407 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold cancel
This workaround did not improve the compute-migrations stability as we had hoped and there is a risk that this can break if pod restarts occur.
This reverts commit 24872e9. Signed-off-by: Jed Lejosne <jed@redhat.com>
Required labels detected, running phase 2 presubmits: |
What this PR does
This reverts the workaround added by #13443, as I believe it is now hurting us more than helping.
Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note