Tests: General improvements to make tests work with WFFC #13954

alromeros · 2025-02-14T17:35:52Z

What this PR does

Volume Hotplug tests are failing in clusters with node affinity constraints due to forced PVC binding, rendering the hotplug pod unschedulable.

This Pull Request aims to remove force-binding for volume hotplug tests, allowing the scheduler to do its job.

It also increases some timeouts and changes DV phase expectations in a couple of tests so they can pass with WFFC.

Fixes #

Release note

NONE

kubevirt-bot · 2025-02-14T17:35:55Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

alromeros · 2025-02-14T17:36:21Z

/test pull-kubevirt-e2e-k8s-1.32-sig-storage
/test pull-kubevirt-e2e-k8s-1.31-sig-storage

alromeros · 2025-02-17T16:23:09Z

/test pull-kubevirt-e2e-k8s-1.32-sig-storage
/test pull-kubevirt-e2e-k8s-1.31-sig-storage

alromeros · 2025-02-18T09:26:05Z

/test pull-kubevirt-e2e-k8s-1.32-sig-storage
/test pull-kubevirt-e2e-k8s-1.31-sig-storage

alromeros · 2025-02-19T09:35:36Z

/retest-required

akalenyu

seems fine! just worried this could break day-2 wffc testing. I believe it should be testable if you slightly edit the ceph test config fields to all point at ceph-wffc

kubevirt/tests/default-ceph-config.json

Lines 1 to 10 in 0e18196

    
           { 
        
               "storageClassRhel":        "rook-ceph-block", 
        
               "storageClassWindows":     "rook-ceph-block", 
        
               "storageRWXFileSystem":    "nfs-csi", 
        
               "storageRWXBlock":         "rook-ceph-block", 
        
               "storageRWOFileSystem":    "local", 
        
               "storageRWOBlock":         "rook-ceph-block", 
        
               "storageSnapshot":         "rook-ceph-block", 
        
               "storageVMState":          "rook-ceph-block" 
        
           }

(maybe except rwxfs)

akalenyu · 2025-02-19T10:21:08Z

tests/storage/hotplug.go

@@ -476,12 +476,11 @@ var _ = SIGDescribe("Hotplug", func() {
 				libdv.StorageWithAccessMode(accessMode),
 				libdv.StorageWithVolumeMode(volumeMode),
 			),
-			libdv.WithForceBindAnnotation(),


createDataVolumeAndWaitForImport is used a lot throughout this suite, does this really not break anything?
any chance you could run the hotplug suite against rook-ceph-wffc?

alromeros · 2025-02-19T10:43:43Z

/test pull-kubevirt-e2e-k8s-1.32-sig-storage

alromeros · 2025-02-19T18:17:27Z

/test pull-kubevirt-e2e-k8s-1.32-sig-storage
/test pull-kubevirt-e2e-k8s-1.31-sig-storage

alromeros · 2025-02-20T12:16:17Z

/test pull-kubevirt-e2e-k8s-1.31-sig-storage

alromeros · 2025-02-20T15:48:07Z

/test pull-kubevirt-e2e-k8s-1.32-sig-storage
/test pull-kubevirt-e2e-k8s-1.31-sig-storage

akalenyu · 2025-03-31T13:26:14Z

tests/storage/hotplug.go

@@ -239,6 +239,9 @@ var _ = Describe(SIG("Hotplug", func() {
 		for _, volumeName := range volumeNames {
 			nameMap[volumeName] = true
 		}
+		defaultSecs := 180
+		// timeout is calculated based on the number of volumes to be attached
+		timeout := time.Duration(defaultSecs+(len(volumeNames)/25)*defaultSecs) * time.Second


Do you still need this?

I considered removing it but still think it could be benefitial in WFFC clusters that meet the storage pool requirements. Can remove it if preferred.

Yeah this is seems too complex to me

akalenyu · 2025-03-31T13:26:52Z

tests/storage/hotplug.go

+						libdv.StorageWithVolumeSize("500Mi"),
+						libdv.StorageWithVolumeMode(k8sv1.PersistentVolumeFilesystem),


Same question about this?

Yeah I'd say we do, better to be more imperative with the volume mode here since we want FS for this DV.

We do? I think @awels intention is to use whatever is available in the test config (block/fs)

We need to rename the disk image from this DV, so at least based on how the test is structured, it needs to be FS to access it and rename it. That's why we use the storage class from GetRWOFileSystemStorageClass, assuming the default volume mode will be FS.

Was looking at the wrong test 🤦‍♂️

kubevirt-bot · 2025-03-31T16:22:43Z

@alromeros: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubevirt-e2e-k8s-1.31-sig-compute-migrations	`0e18196`	link	true	`/test pull-kubevirt-e2e-k8s-1.31-sig-compute-migrations`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Volume Hotplug tests are failing in clusters with node affinity constraints due to forced PVC binding, rendering the hotplug pod unschedulable. This change removes force-binding for volume hotplug tests, allowing the scheduler to do its job. Signed-off-by: Alvaro Romero <alromero@redhat.com>

Signed-off-by: Alvaro Romero <alromero@redhat.com>

akalenyu

/approve
/lgtm

/cc @0xFelix
for formal approval over decorators

0xFelix

/approve

Giving a chance to address the nit

/hold

0xFelix · 2025-04-01T08:58:39Z

tests/decorators/decorators.go

+
+	// LargeStoragePoolrequired indicates that the test may fail in a cluster with a low storage pool capacity.
+	// This decorator can be used to skip the test as the failure might not indicate a functional problem.
+	LargeStoragePoolrequired = Label("large-storage-pool-required")


Suggested change

LargeStoragePoolrequired = Label("large-storage-pool-required")

LargeStoragePoolRequired = Label("large-storage-pool-required")

nit

Good catch! ack

kubevirt-bot · 2025-04-01T09:00:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix, akalenyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~tests/OWNERS~~ [0xFelix]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-commenter-bot · 2025-04-01T09:00:51Z

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-1.30-vgpu
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.32-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.30-sig-network
/test pull-kubevirt-e2e-k8s-1.30-sig-storage
/test pull-kubevirt-e2e-k8s-1.30-sig-compute
/test pull-kubevirt-e2e-k8s-1.30-sig-operator
/test pull-kubevirt-e2e-k8s-1.31-sig-network
/test pull-kubevirt-e2e-k8s-1.31-sig-storage
/test pull-kubevirt-e2e-k8s-1.31-sig-compute
/test pull-kubevirt-e2e-k8s-1.31-sig-operator

Signed-off-by: Alvaro Romero <alromero@redhat.com>

kubevirt-commenter-bot · 2025-04-01T09:08:43Z

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-1.30-vgpu
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.32-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.30-sig-network
/test pull-kubevirt-e2e-k8s-1.30-sig-storage
/test pull-kubevirt-e2e-k8s-1.30-sig-compute
/test pull-kubevirt-e2e-k8s-1.30-sig-operator
/test pull-kubevirt-e2e-k8s-1.31-sig-network
/test pull-kubevirt-e2e-k8s-1.31-sig-storage
/test pull-kubevirt-e2e-k8s-1.31-sig-compute
/test pull-kubevirt-e2e-k8s-1.31-sig-operator

0xFelix · 2025-04-01T09:13:30Z

/hold cancel

alromeros · 2025-04-02T16:48:59Z

/cherry-pick release-1.5

kubevirt-bot · 2025-04-02T16:49:39Z

@alromeros: new pull request created: #14410

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubevirt-bot added do-not-merge/work-in-progress release-note-none labels Feb 14, 2025

kubevirt-bot requested a review from akalenyu February 14, 2025 17:35

kubevirt-bot added the dco-signoff: yes label Feb 14, 2025

kubevirt-bot requested a review from awels February 14, 2025 17:35

kubevirt-bot added sig/storage size/XS labels Feb 14, 2025

alromeros force-pushed the stop-forcebind-hotplug branch from fcbcf60 to 149dd07 Compare February 17, 2025 16:22

alromeros force-pushed the stop-forcebind-hotplug branch from 149dd07 to 0e18196 Compare February 18, 2025 09:25

alromeros marked this pull request as ready for review February 18, 2025 19:27

kubevirt-bot removed the do-not-merge/work-in-progress label Feb 18, 2025

kubevirt-bot requested a review from ShellyKa13 February 18, 2025 19:27

dosubot bot added kind/failing-test sig/testing labels Feb 18, 2025

akalenyu reviewed Feb 19, 2025

View reviewed changes

alromeros marked this pull request as draft February 19, 2025 10:40

kubevirt-bot added do-not-merge/work-in-progress size/S and removed size/XS labels Feb 19, 2025

alromeros force-pushed the stop-forcebind-hotplug branch from 3e7b38e to fb5f213 Compare February 19, 2025 17:47

alromeros force-pushed the stop-forcebind-hotplug branch from b634150 to 810c3f6 Compare February 20, 2025 12:08

akalenyu reviewed Mar 31, 2025

View reviewed changes

alromeros requested a review from akalenyu April 1, 2025 07:45

alromeros added 2 commits April 1, 2025 10:01

Update tests to work with WFFC storage classes

26e886b

Signed-off-by: Alvaro Romero <alromero@redhat.com>

alromeros force-pushed the stop-forcebind-hotplug branch from 2e01c1c to 5ffba05 Compare April 1, 2025 08:01

kubevirt-bot added size/S and removed size/M labels Apr 1, 2025

akalenyu reviewed Apr 1, 2025

View reviewed changes

kubevirt-bot requested a review from 0xFelix April 1, 2025 08:13

kubevirt-bot assigned akalenyu Apr 1, 2025

kubevirt-bot added the lgtm label Apr 1, 2025

0xFelix reviewed Apr 1, 2025

View reviewed changes

kubevirt-bot added the do-not-merge/hold label Apr 1, 2025

kubevirt-bot added the approved label Apr 1, 2025

Add decorator to skip test that requires high storage pool capacity

Loading
Loading status checks…

deb3152

Signed-off-by: Alvaro Romero <alromero@redhat.com>

alromeros force-pushed the stop-forcebind-hotplug branch from 5ffba05 to deb3152 Compare April 1, 2025 09:07

kubevirt-bot removed the lgtm label Apr 1, 2025

akalenyu approved these changes Apr 1, 2025

View reviewed changes

kubevirt-bot added the lgtm label Apr 1, 2025

kubevirt-bot removed the do-not-merge/hold label Apr 1, 2025

kubevirt-bot merged commit db3f011 into kubevirt:main Apr 1, 2025
38 checks passed

kubevirt-bot mentioned this pull request Apr 2, 2025

[release-1.5] Tests: General improvements to make tests work with WFFC #14410

Merged

	{
	"storageClassRhel": "rook-ceph-block",
	"storageClassWindows": "rook-ceph-block",
	"storageRWXFileSystem": "nfs-csi",
	"storageRWXBlock": "rook-ceph-block",
	"storageRWOFileSystem": "local",
	"storageRWOBlock": "rook-ceph-block",
	"storageSnapshot": "rook-ceph-block",
	"storageVMState": "rook-ceph-block"
	}

		libdv.StorageWithVolumeSize("500Mi"),
		libdv.StorageWithVolumeMode(k8sv1.PersistentVolumeFilesystem),

	LargeStoragePoolrequired = Label("large-storage-pool-required")
	LargeStoragePoolRequired = Label("large-storage-pool-required")

Tests: General improvements to make tests work with WFFC #13954

Tests: General improvements to make tests work with WFFC #13954

Uh oh!

Conversation

alromeros commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does

Release note

Uh oh!

kubevirt-bot commented Feb 14, 2025

Uh oh!

alromeros commented Feb 14, 2025

Uh oh!

alromeros commented Feb 17, 2025

Uh oh!

alromeros commented Feb 18, 2025

Uh oh!

alromeros commented Feb 19, 2025

Uh oh!

akalenyu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alromeros commented Feb 19, 2025

Uh oh!

alromeros commented Feb 19, 2025

Uh oh!

alromeros commented Feb 20, 2025

Uh oh!

alromeros commented Feb 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kubevirt-bot commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akalenyu left a comment

Choose a reason for hiding this comment

Uh oh!

0xFelix left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kubevirt-bot commented Apr 1, 2025

Uh oh!

kubevirt-commenter-bot commented Apr 1, 2025

Uh oh!

Uh oh!

kubevirt-commenter-bot commented Apr 1, 2025

Uh oh!

0xFelix commented Apr 1, 2025

Uh oh!

Uh oh!

alromeros commented Apr 2, 2025

Uh oh!

kubevirt-bot commented Apr 2, 2025

Uh oh!

alromeros commented Feb 14, 2025 •

edited

Loading

akalenyu left a comment •

edited

Loading

kubevirt-bot commented Mar 31, 2025 •

edited

Loading