Skip to content

[release-1.3] [bugFix]: Fix panic in virt-handler when process is not found during CPU housekeeping #13231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2024
Merged

[release-1.3] [bugFix]: Fix panic in virt-handler when process is not found during CPU housekeeping #13231

merged 1 commit into from
Dec 10, 2024
+6 −1

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #13216

/assign xpivarc

NONE

@Barakmor1
Fix panic in virt-handler when process is not found during CPU housek…
Loading
Loading status checks…
0329c86 
…eeping The FindProcess function from go-ps pkg returns nil without error if a process isn't found, but our code incorrectly assumes an error. This commit adds a check to ensure the process is not nil before invoking its methods, preventing the panic.

Signed-off-by: bmordeha <bmordeha@redhat.com>
@kubevirt-bot kubevirt-bot mentioned this pull request Nov 11, 2024
Merged
8 tasks
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Nov 11, 2024
@dosubot dosubot bot added kind/bug priority/critical-urgent Categorizes an issue or pull request as critical and of urgent priority. sig/compute labels Nov 11, 2024
@fossedihelm
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2024
@fossedihelm
Copy link
Contributor

/hold
#13230 first

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2024
@fossedihelm fossedihelm mentioned this pull request Nov 12, 2024
Merged
@fossedihelm
Copy link
Contributor

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2024
@fossedihelm
Copy link
Contributor

@xpivarc ping

@kubevirt-bot
Copy link
Contributor Author

Pull requests that are marked with lgtm should receive a review
from an approver within 1 week.

After that period the bot marks them with the label needs-approver-review.

/label needs-approver-review

@kubevirt-bot kubevirt-bot added the needs-approver-review Indicates that a PR requires a review from an approver. label Nov 25, 2024
@dasionov
Copy link
Contributor

dasionov commented Dec 2, 2024

@xpivarc gentle ping

xpivarc
xpivarc reviewed Dec 10, 2024
View reviewed changes
Copy link
Member

@xpivarc xpivarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xpivarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024
@kubevirt-bot
Copy link
Contributor Author

@kubevirt-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-e2e-k8s-1.30-sig-compute-migrations 0329c86 link unknown /test pull-kubevirt-e2e-k8s-1.30-sig-compute-migrations-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kubevirt-bot kubevirt-bot merged commit 218aa05 into kubevirt:release-1.3 Dec 10, 2024
34 of 36 checks passed
@kubevirt-bot
Copy link
Contributor Author

/remove-label needs-approver-review

@kubevirt-bot kubevirt-bot removed the needs-approver-review Indicates that a PR requires a review from an approver. label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xpivarc xpivarc

@enp0s3 enp0s3

@victortoso victortoso

Assignees

@fossedihelm fossedihelm

@xpivarc xpivarc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug lgtm Indicates that a PR is ready to be merged. priority/critical-urgent Categorizes an issue or pull request as critical and of urgent priority. release-note-none Denotes a PR that doesn't merit a release note. sig/compute size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kubevirt-bot @fossedihelm @dasionov @xpivarc @Barakmor1