Skip to content

backend-storage: fix broken annotation name #13219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

jean-edouard
Copy link
Contributor

What this PR does

Before this PR:
The annotation name used to find the default virt storage class was taken from a design proposal draft, and was changed in the final version.

After this PR:
The correct annotation is used.

Fixes #

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note

backend-storage will now correctly use the default virtualization storage class

Sorry, something went wrong.

Signed-off-by: Jed Lejosne <jed@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 11, 2024
@dosubot dosubot bot added the kind/bug label Nov 11, 2024
@akalenyu
Copy link
Contributor

whoops!
/lgtm
/cc @mhenriks

I think it makes sense to expose thist const via the CDI API package

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2024
@jean-edouard
Copy link
Contributor Author

/cherry-pick release-1.4
/cherry-pick release-1.3

@kubevirt-bot
Copy link
Contributor

@jean-edouard: once the present PR merges, I will cherry-pick it on top of release-1.3, release-1.4 in new PRs and assign them to you.

In response to this:

/cherry-pick release-1.4
/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@xpivarc xpivarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xpivarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2024
@kubevirt-commenter-bot
Copy link

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-1.30-vgpu
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.30-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.29-sig-network
/test pull-kubevirt-e2e-k8s-1.29-sig-storage
/test pull-kubevirt-e2e-k8s-1.29-sig-compute
/test pull-kubevirt-e2e-k8s-1.29-sig-operator
/test pull-kubevirt-e2e-k8s-1.30-sig-network
/test pull-kubevirt-e2e-k8s-1.30-sig-storage
/test pull-kubevirt-e2e-k8s-1.30-sig-compute
/test pull-kubevirt-e2e-k8s-1.30-sig-operator

@xpivarc xpivarc added the priority/critical-urgent Categorizes an issue or pull request as critical and of urgent priority. label Nov 11, 2024
@kubevirt-bot kubevirt-bot merged commit cf8adaf into kubevirt:main Nov 11, 2024
31 of 38 checks passed
@kubevirt-bot
Copy link
Contributor

@jean-edouard: new pull request created: #13225

In response to this:

/cherry-pick release-1.4
/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot
Copy link
Contributor

@jean-edouard: new pull request created: #13227

In response to this:

/cherry-pick release-1.4
/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug lgtm Indicates that a PR is ready to be merged. priority/critical-urgent Categorizes an issue or pull request as critical and of urgent priority. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants