Skip to content

gocli: Add wait for cri-o service to be ready after proxy settings applied #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2024
Merged

gocli: Add wait for cri-o service to be ready after proxy settings applied #1303

merged 2 commits into from
Oct 18, 2024
+9 −0

Conversation

brianmcarey
Copy link
Member

What this PR does / why we need it:

There was previously a wait for the cri-o service to be ready[1] after applying the docker proxy settings but this was not included with the introduction of the opts package[2].

This can lead to kubeadm failing its preflight checks as cri-o is not ready[3]

[1]

kubevirtci/cluster-provision/k8s/1.31/nodes.sh

Line 43 in 03aa94e

while [[ `systemctl status crio | grep active | wc -l` -eq 0 ]]

[2] #1217
[3] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/13020/pull-kubevirt-e2e-k8s-1.31-sig-network/1843292337933914112#1:build-log.txt%3A343

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @aerosouund @xpivarc

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

Sorry, something went wrong.

@brianmcarey
gocli: Add wait for cri-o service to be ready after proxy settings ap…
Loading
Loading status checks…
61a726f 
…plied

There was previously a wait for the cri-o service to be ready[1] after
applying the docker proxy settings but this was not included with the
introduction of the opts package[2].

This can lead to kubeadm failing its preflight checks as cri-o is not ready[3]

[1] https://github.com/kubevirt/kubevirtci/blob/03aa94e9da974b0e37dc8f180a4f700d47020c08/cluster-provision/k8s/1.31/nodes.sh#L43
[2] kubevirt#1217
[3] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/13020/pull-kubevirt-e2e-k8s-1.31-sig-network/1843292337933914112#1:build-log.txt%3A343

Signed-off-by: Brian Carey <bcarey@redhat.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Oct 16, 2024
@brianmcarey brianmcarey force-pushed the wait-for-crio-service branch from 8621b1c to 593a277 Compare October 17, 2024 07:06
@brianmcarey
gocli: Add wait for crio service to node opts
Loading
Loading status checks…
f1606f9 
Signed-off-by: Brian Carey <bcarey@redhat.com>
@brianmcarey brianmcarey force-pushed the wait-for-crio-service branch from 593a277 to f1606f9 Compare October 17, 2024 07:37
@brianmcarey
Copy link
Member Author

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirtci/1303/check-provision-k8s-1.30/1846817695127834624#1:build-log.txt%3A1883

@aerosouund
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2024
@brianmcarey
Copy link
Member Author

/override check-up-kind-sriov

see #1305

@kubevirt-bot
Copy link
Contributor

@brianmcarey: Overrode contexts on behalf of brianmcarey: check-up-kind-sriov

In response to this:

/override check-up-kind-sriov

see #1305

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@brianmcarey
Copy link
Member Author

@xpivarc - check-provisions have passed here

xpivarc
xpivarc reviewed Oct 18, 2024
View reviewed changes
Copy link
Member

@xpivarc xpivarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xpivarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2024
@brianmcarey
Copy link
Member Author

/override check-up-kind-sriov

@kubevirt-bot
Copy link
Contributor

@brianmcarey: Overrode contexts on behalf of brianmcarey: check-up-kind-sriov

In response to this:

/override check-up-kind-sriov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Oct 18, 2024 •
edited
Loading

@brianmcarey: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-up-kind-1.30-vgpu f1606f9 link false /test check-up-kind-1.30-vgpu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@brianmcarey
Copy link
Member Author

/override check-provision-k8s-1.30

No tests failed - the lane timed out. It has already passed against this PR.

@kubevirt-bot
Copy link
Contributor

@brianmcarey: Overrode contexts on behalf of brianmcarey: check-provision-k8s-1.30

In response to this:

/override check-provision-k8s-1.30

No tests failed - the lane timed out. It has already passed against this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot merged commit 1cedd17 into kubevirt:main Oct 18, 2024
9 of 10 checks passed
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Oct 18, 2024
@kubevirt-bot
Bump kubevirtci
c9d8cca 
[1cedd17 gocli: Add wait for cri-o service to be ready after proxy settings applied](kubevirt/kubevirtci#1303)
[0f94b65 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1292)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
@kubevirt-bot kubevirt-bot mentioned this pull request Oct 18, 2024
Merged
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Oct 19, 2024
@kubevirt-bot
Bump kubevirtci
fe941ba 
[1cedd17 gocli: Add wait for cri-o service to be ready after proxy settings applied](kubevirt/kubevirtci#1303)
[0f94b65 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1292)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Oct 19, 2024
@kubevirt-bot
Bump kubevirtci
215270c 
[1cedd17 gocli: Add wait for cri-o service to be ready after proxy settings applied](kubevirt/kubevirtci#1303)
[0f94b65 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1292)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Oct 20, 2024
@kubevirt-bot
Bump kubevirtci
6a320b4 
[1cedd17 gocli: Add wait for cri-o service to be ready after proxy settings applied](kubevirt/kubevirtci#1303)
[0f94b65 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1292)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Oct 20, 2024
@kubevirt-bot
Bump kubevirtci
5d6de62 
[1cedd17 gocli: Add wait for cri-o service to be ready after proxy settings applied](kubevirt/kubevirtci#1303)
[0f94b65 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1292)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Oct 21, 2024
@kubevirt-bot
Bump kubevirtci
e9e78cb 
[1cedd17 gocli: Add wait for cri-o service to be ready after proxy settings applied](kubevirt/kubevirtci#1303)
[0f94b65 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1292)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xpivarc xpivarc

@aerosouund aerosouund

Assignees

@aerosouund aerosouund

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brianmcarey @aerosouund @kubevirt-bot @xpivarc