Skip to content

Add kubevirt_vm_resource_requests metric for memory resource #12593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2024
Merged

Add kubevirt_vm_resource_requests metric for memory resource #12593

merged 1 commit into from
Aug 27, 2024
+102 −2

Conversation

machadovilaca
Copy link
Member

@machadovilaca machadovilaca commented Aug 14, 2024 •
edited
Loading

What this PR does

Before this PR:

No metric with VM resource requests data

After this PR:

kubevirt_vm_resource_requests hold memory resource requests for VMs

jira-ticket: https://issues.redhat.com/browse/CNV-44275

Fixes #

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note

Add kubevirt_vm_resource_requests metric for memory resource

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Aug 14, 2024
@machadovilaca
Copy link
Member Author

/cc @sradco @avlitman

@kubevirt-bot kubevirt-bot added the sig/observability Denotes an issue or PR that relates to observability. label Aug 14, 2024
@machadovilaca machadovilaca force-pushed the add-vmi-and-pod-requested-memory branch 2 times, most recently from 0ebd516 to b6fd3a0 Compare August 19, 2024 13:24
@machadovilaca machadovilaca mentioned this pull request Aug 19, 2024
Merged
8 tasks
@machadovilaca machadovilaca force-pushed the add-vmi-and-pod-requested-memory branch from b6fd3a0 to 8965d70 Compare August 19, 2024 13:53
@machadovilaca
Copy link
Member Author

/retest

@avlitman
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2024
@sradco
Copy link
Contributor

sradco commented Aug 20, 2024

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2024
@machadovilaca machadovilaca force-pushed the add-vmi-and-pod-requested-memory branch from 8965d70 to dee9bdb Compare August 21, 2024 13:43
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2024
@machadovilaca
Add kubevirt_vm_resource_requests for memory resource
Loading
Loading status checks…
81e43b1 
Signed-off-by: João Vilaça <machadovilaca@gmail.com>
@machadovilaca machadovilaca force-pushed the add-vmi-and-pod-requested-memory branch from dee9bdb to 81e43b1 Compare August 21, 2024 13:43
sradco
sradco reviewed Aug 22, 2024
View reviewed changes
docs/metrics.md
@@ -93,6 +93,9 @@ Virtual Machine last transition timestamp to migrating status. Type: Counter.
### kubevirt_vm_non_running_status_last_transition_timestamp_seconds
Virtual Machine last transition timestamp to paused/stopped status. Type: Counter.

### kubevirt_vm_resource_requests
Resources requested by Virtual Machine. Type: Gauge.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@machadovilaca Can you please mention these are CPU and memory requests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cpu will only be added in #12625

@sradco
Copy link
Contributor

sradco commented Aug 23, 2024

/approve

@sradco
Copy link
Contributor

sradco commented Aug 23, 2024

/hold

@sradco
Copy link
Contributor

sradco commented Aug 23, 2024 •
edited
Loading

@machadovilaca Please update pr name and description

@machadovilaca machadovilaca changed the title Add kubevirt_vmi_resource_requests metric for memory resource Add kubevirt_vm_resource_requests metric for memory resource Aug 26, 2024
@sradco
Copy link
Contributor

sradco commented Aug 26, 2024

/approve

@machadovilaca
Copy link
Member Author

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2024
@avlitman
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2024
@enp0s3
Copy link
Contributor

enp0s3 commented Aug 26, 2024

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enp0s3, sradco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2024
@kubevirt-commenter-bot
Copy link

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-1.27-vgpu
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.30-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.28-sig-network
/test pull-kubevirt-e2e-k8s-1.28-sig-storage
/test pull-kubevirt-e2e-k8s-1.28-sig-compute
/test pull-kubevirt-e2e-k8s-1.28-sig-operator
/test pull-kubevirt-e2e-k8s-1.29-sig-network
/test pull-kubevirt-e2e-k8s-1.29-sig-storage
/test pull-kubevirt-e2e-k8s-1.29-sig-compute
/test pull-kubevirt-e2e-k8s-1.29-sig-operator

@machadovilaca
Copy link
Member Author

/retest-required

@kubevirt-bot kubevirt-bot merged commit 3b5b892 into kubevirt:main Aug 27, 2024
42 checks passed
@machadovilaca machadovilaca deleted the add-vmi-and-pod-requested-memory branch August 27, 2024 07:49
@machadovilaca machadovilaca mentioned this pull request Oct 24, 2024
Merged
8 tasks
@machadovilaca machadovilaca mentioned this pull request Dec 12, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sradco sradco

@avlitman avlitman

@assafad assafad

Assignees

@avlitman avlitman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/observability Denotes an issue or PR that relates to observability. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@machadovilaca @avlitman @sradco @enp0s3 @kubevirt-bot @kubevirt-commenter-bot