Skip to content

virtctl/imageupload progress bar: write to stdout #12523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2024
Merged

virtctl/imageupload progress bar: write to stdout #12523

merged 1 commit into from
Aug 7, 2024
+6 −3

Conversation

akalenyu
Copy link
Contributor

@akalenyu akalenyu commented Aug 4, 2024

What this PR does

We've been using an older progress bar library for ages now that defaulted to stdout:
#12184
Let's keep it that way

Fixes #

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note

NONE

Sorry, something went wrong.

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. area/virtctl size/XS labels Aug 4, 2024
@kubevirt-bot kubevirt-bot requested review from EdDev and oshoval August 4, 2024 11:23
@akalenyu
Copy link
Contributor Author

akalenyu commented Aug 4, 2024

/cc @xpivarc @0xFelix

@kubevirt-bot kubevirt-bot requested review from 0xFelix and xpivarc August 4, 2024 11:25
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2024
0xFelix
0xFelix reviewed Aug 5, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2024
@kubevirt-commenter-bot
Copy link

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-1.27-vgpu
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.30-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.28-sig-network
/test pull-kubevirt-e2e-k8s-1.28-sig-storage
/test pull-kubevirt-e2e-k8s-1.28-sig-compute
/test pull-kubevirt-e2e-k8s-1.28-sig-operator
/test pull-kubevirt-e2e-k8s-1.29-sig-network
/test pull-kubevirt-e2e-k8s-1.29-sig-storage
/test pull-kubevirt-e2e-k8s-1.29-sig-compute
/test pull-kubevirt-e2e-k8s-1.29-sig-operator

@0xFelix
Copy link
Member

0xFelix commented Aug 5, 2024

Can / should we add a test for the expected output by the way?

@oshoval
Copy link
Contributor

oshoval commented Aug 5, 2024

Can / should we add a test for the expected output by the way?

imho no need over testing

@0xFelix
Copy link
Member

0xFelix commented Aug 5, 2024

The change which is being reversed with this PR went unnoticed because there were no tests.

@akalenyu
Copy link
Contributor Author

akalenyu commented Aug 5, 2024

The change which is being reversed with this PR went unnoticed because there were no tests.

Sure thing, I'll add that
/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2024
@oshoval
Copy link
Contributor

oshoval commented Aug 5, 2024

The change which is being reversed with this PR went unnoticed because there were no tests.

Still, i think that some tests are born due to a bug,
if there was no bug in the original development, they were not added
in this case i think that each test should be considered if this code is prone for changes / part of the core
or not,
in this case i think it is not one of those, hence the fact there was a bug doesnt merit a test imho

@akalenyu
virtctl/imageupload progress bar: write to stdout
Loading
Loading status checks…
7264360 
We've been using an older progress bar library for ages now
that defaulted to stdout:
kubevirt#12184
Let's keep it that way

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
@akalenyu akalenyu force-pushed the imageupload-bar-stdout branch from b8d30ac to 7264360 Compare August 5, 2024 14:14
@kubevirt-bot kubevirt-bot added sig/storage and removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 5, 2024
@akalenyu
Copy link
Contributor Author

akalenyu commented Aug 5, 2024

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2024
0xFelix
0xFelix approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Not allowed to approve in tests/storage.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2024
@akalenyu
Copy link
Contributor Author

akalenyu commented Aug 6, 2024

/cc @xpivarc

xpivarc
xpivarc reviewed Aug 6, 2024
View reviewed changes
Copy link
Member

@xpivarc xpivarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix, xpivarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2024
@kubevirt-commenter-bot
Copy link

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-1.27-vgpu
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.30-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.28-sig-network
/test pull-kubevirt-e2e-k8s-1.28-sig-storage
/test pull-kubevirt-e2e-k8s-1.28-sig-compute
/test pull-kubevirt-e2e-k8s-1.28-sig-operator
/test pull-kubevirt-e2e-k8s-1.29-sig-network
/test pull-kubevirt-e2e-k8s-1.29-sig-storage
/test pull-kubevirt-e2e-k8s-1.29-sig-compute
/test pull-kubevirt-e2e-k8s-1.29-sig-operator

aglitke
aglitke reviewed Aug 6, 2024
View reviewed changes
Copy link
Member

@aglitke aglitke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot
Copy link
Contributor

@akalenyu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-e2e-k8s-1.28-sig-storage 7264360 link unknown /test pull-kubevirt-e2e-k8s-1.28-sig-storage
pull-kubevirt-e2e-k8s-1.30-sig-storage 7264360 link unknown /test pull-kubevirt-e2e-k8s-1.30-sig-storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kubevirt-bot kubevirt-bot merged commit 1e94603 into kubevirt:main Aug 7, 2024
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aglitke aglitke

@xpivarc xpivarc

@0xFelix 0xFelix

@oshoval oshoval

@EdDev EdDev

Assignees

@aglitke aglitke

@0xFelix 0xFelix

@oshoval oshoval

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/virtctl dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/storage size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@akalenyu @kubevirt-commenter-bot @0xFelix @oshoval @kubevirt-bot @aglitke @xpivarc