Skip to content

[release-1.3] Implement retries in vmexport download when server returns unexpected status #12151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 25, 2024
Merged

[release-1.3] Implement retries in vmexport download when server returns unexpected status #12151

merged 6 commits into from
Jun 25, 2024
+222 −78

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #11911

/assign alromeros

Bugfix: Implement retry mechanism in export server and vmexport

alromeros added 6 commits June 18, 2024 11:36
@alromeros
Improve error handling in export server when pod lacks read permissions
2f12792 
Signed-off-by: Alvaro Romero <alromero@redhat.com>
@alromeros
Implement retry mechanism in vmexport download
972c781 
This commit implements a retry mechanism in the vmexport download command so, when the export server returns an unexpected status, we retry the download again.

Signed-off-by: Alvaro Romero <alromero@redhat.com>
@alromeros
Adapt unit tests
a18bcdb 
Signed-off-by: Alvaro Romero <alromero@redhat.com>
@alromeros
Add retry flag to vmexport download
f5d829e 
This commit adds a flag that lets users specify the number of retrys the command will attempt before giving up.

Signed-off-by: Alvaro Romero <alromero@redhat.com>
@alromeros
Shut down export server during initialization if it lacks permissions
99fdc00 
Signed-off-by: Alvaro Romero <alromero@redhat.com>
@alromeros
Add readiness probe to exporter pod
Loading
Loading status checks…
274666b 
Signed-off-by: Alvaro Romero <alromero@redhat.com>
@kubevirt-bot kubevirt-bot mentioned this pull request Jun 18, 2024
Merged
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 18, 2024
@kubevirt-bot kubevirt-bot requested review from akalenyu and oshoval June 18, 2024 11:36
@kubevirt-bot kubevirt-bot added area/virtctl sig/buildsystem Denotes an issue or PR that relates to changes in the build system. sig/storage size/L labels Jun 18, 2024
@alromeros
Copy link
Contributor

Jira to justify backport: https://issues.redhat.com/browse/CNV-43128

@alromeros
Copy link
Contributor

/test pull-kubevirt-e2e-k8s-1.30-sig-storage-1.3

@alromeros
Copy link
Contributor

/retest

@alromeros
Copy link
Contributor

/test pull-kubevirt-e2e-k8s-1.30-sig-storage-1.3

1 similar comment
@alromeros
Copy link
Contributor

/test pull-kubevirt-e2e-k8s-1.30-sig-storage-1.3

@mhenriks
Copy link
Member

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2024
@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2024
@kubevirt-bot
Copy link
Contributor Author

@brianmcarey: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-kubevirt-apidocs-1.3
  • /test pull-kubevirt-build-1.3
  • /test pull-kubevirt-build-arm64-1.3
  • /test pull-kubevirt-check-unassigned-tests-1.3
  • /test pull-kubevirt-client-python-1.3
  • /test pull-kubevirt-code-lint-1.3
  • /test pull-kubevirt-e2e-k8s-1.28-sig-compute-1.3
  • /test pull-kubevirt-e2e-k8s-1.28-sig-network-1.3
  • /test pull-kubevirt-e2e-k8s-1.28-sig-operator-1.3
  • /test pull-kubevirt-e2e-k8s-1.28-sig-storage-1.3
  • /test pull-kubevirt-e2e-k8s-1.29-sig-compute-1.3
  • /test pull-kubevirt-e2e-k8s-1.29-sig-monitoring-1.3
  • /test pull-kubevirt-e2e-k8s-1.29-sig-network-1.3
  • /test pull-kubevirt-e2e-k8s-1.29-sig-operator-1.3
  • /test pull-kubevirt-e2e-k8s-1.29-sig-performance-1.3
  • /test pull-kubevirt-e2e-k8s-1.29-sig-storage-1.3
  • /test pull-kubevirt-e2e-k8s-1.30-ipv6-sig-network-1.3
  • /test pull-kubevirt-e2e-k8s-1.30-sig-compute-1.3
  • /test pull-kubevirt-e2e-k8s-1.30-sig-compute-migrations-1.3
  • /test pull-kubevirt-e2e-k8s-1.30-sig-compute-serial-1.3
  • /test pull-kubevirt-e2e-k8s-1.30-sig-network-1.3
  • /test pull-kubevirt-e2e-k8s-1.30-sig-operator-1.3
  • /test pull-kubevirt-e2e-k8s-1.30-sig-storage-1.3
  • /test pull-kubevirt-e2e-kind-sriov-1.3
  • /test pull-kubevirt-e2e-windows2016-1.3
  • /test pull-kubevirt-generate-1.3
  • /test pull-kubevirt-manifests-1.3
  • /test pull-kubevirt-prom-rules-verify-1.3
  • /test pull-kubevirt-unit-test-1.3
  • /test pull-kubevirt-verify-go-mod-1.3

The following commands are available to trigger optional jobs:

  • /test build-kubevirt-builder-1.3
  • /test pull-kubevirt-build-s390x-1.3
  • /test pull-kubevirt-check-tests-for-flakes-1.3
  • /test pull-kubevirt-conformance-arm64-1.3
  • /test pull-kubevirt-e2e-arm64-1.3
  • /test pull-kubevirt-e2e-k8s-1.29-sig-compute-realtime-1.3
  • /test pull-kubevirt-e2e-k8s-1.29-sig-compute-root-1.3
  • /test pull-kubevirt-e2e-k8s-1.29-sig-network-multus-v4-1.3
  • /test pull-kubevirt-e2e-k8s-1.29-sig-storage-root-1.3
  • /test pull-kubevirt-e2e-k8s-1.29-single-node-1.3
  • /test pull-kubevirt-e2e-k8s-1.29-swap-enabled-1.3
  • /test pull-kubevirt-e2e-kind-1.27-vgpu-1.3
  • /test pull-kubevirt-gosec-1.3
  • /test pull-kubevirt-goveralls-1.3
  • /test pull-kubevirt-metrics-lint-1.3
  • /test pull-kubevirt-unit-test-arm64-1.3
  • /test pull-kubevirt-verify-rpms-1.3

Use /test all to run the following jobs that were automatically triggered:

  • pull-kubevirt-apidocs-1.3
  • pull-kubevirt-build-1.3
  • pull-kubevirt-build-arm64-1.3
  • pull-kubevirt-check-tests-for-flakes-1.3
  • pull-kubevirt-check-unassigned-tests-1.3
  • pull-kubevirt-client-python-1.3
  • pull-kubevirt-code-lint-1.3
  • pull-kubevirt-conformance-arm64-1.3
  • pull-kubevirt-e2e-arm64-1.3
  • pull-kubevirt-e2e-k8s-1.28-sig-compute-1.3
  • pull-kubevirt-e2e-k8s-1.28-sig-network-1.3
  • pull-kubevirt-e2e-k8s-1.28-sig-operator-1.3
  • pull-kubevirt-e2e-k8s-1.28-sig-storage-1.3
  • pull-kubevirt-e2e-k8s-1.29-sig-compute-1.3
  • pull-kubevirt-e2e-k8s-1.29-sig-network-1.3
  • pull-kubevirt-e2e-k8s-1.29-sig-operator-1.3
  • pull-kubevirt-e2e-k8s-1.29-sig-storage-1.3
  • pull-kubevirt-e2e-k8s-1.30-ipv6-sig-network-1.3
  • pull-kubevirt-e2e-k8s-1.30-sig-compute-1.3
  • pull-kubevirt-e2e-k8s-1.30-sig-compute-migrations-1.3
  • pull-kubevirt-e2e-k8s-1.30-sig-compute-serial-1.3
  • pull-kubevirt-e2e-k8s-1.30-sig-network-1.3
  • pull-kubevirt-e2e-k8s-1.30-sig-operator-1.3
  • pull-kubevirt-e2e-k8s-1.30-sig-storage-1.3
  • pull-kubevirt-e2e-kind-sriov-1.3
  • pull-kubevirt-e2e-windows2016-1.3
  • pull-kubevirt-generate-1.3
  • pull-kubevirt-goveralls-1.3
  • pull-kubevirt-manifests-1.3
  • pull-kubevirt-prom-rules-verify-1.3
  • pull-kubevirt-unit-test-1.3
  • pull-kubevirt-unit-test-arm64-1.3
  • pull-kubevirt-verify-go-mod-1.3

In response to this:

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.30-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.28-sig-network
/test pull-kubevirt-e2e-k8s-1.28-sig-storage
/test pull-kubevirt-e2e-k8s-1.28-sig-compute
/test pull-kubevirt-e2e-k8s-1.28-sig-operator
/test pull-kubevirt-e2e-k8s-1.29-sig-network
/test pull-kubevirt-e2e-k8s-1.29-sig-storage
/test pull-kubevirt-e2e-k8s-1.29-sig-compute
/test pull-kubevirt-e2e-k8s-1.29-sig-operator

These were never triggered due to an issue in project-infra which as been resolved.
kubevirt/project-infra#3478

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@brianmcarey
Copy link
Member

brianmcarey commented Jun 21, 2024 •
edited
Loading

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016-1.3
/test pull-kubevirt-e2e-kind-sriov-1.3
/test pull-kubevirt-e2e-k8s-1.30-ipv6-sig-network-1.3
/test pull-kubevirt-e2e-k8s-1.28-sig-network-1.3
/test pull-kubevirt-e2e-k8s-1.28-sig-storage-1.3
/test pull-kubevirt-e2e-k8s-1.28-sig-compute-1.3
/test pull-kubevirt-e2e-k8s-1.28-sig-operator-1.3
/test pull-kubevirt-e2e-k8s-1.29-sig-network-1.3
/test pull-kubevirt-e2e-k8s-1.29-sig-storage-1.3
/test pull-kubevirt-e2e-k8s-1.29-sig-compute-1.3
/test pull-kubevirt-e2e-k8s-1.29-sig-operator-1.3

These were never triggered due to an issue in project-infra which has been resolved.
kubevirt/project-infra#3478

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

✋🧢

/hold

Dear @kubevirt-commenter-bot

⚠️ this pull request exceeds the number of retests that are allowed per individual commit.

🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present!

Checklist:

💬 How we calculate the number of retests: The number of retest comments are the number of /test or /retest comments after the latest commit only.

👌 After all issues have been resolved, you can remove the hold on this pull request by commenting /unhold on it.

🙇 Thank you, your friendly referee automation, on behalf of the @sig-buildsystem and the KubeVirt community!

Sorry, something went wrong.

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2024
@alromeros
Copy link
Contributor

/retest-required

2 similar comments
@alromeros
Copy link
Contributor

/retest-required

@alromeros
Copy link
Contributor

/retest-required

@alromeros
Copy link
Contributor

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2024
@kubevirt-bot kubevirt-bot merged commit 9a3d2e3 into kubevirt:release-1.3 Jun 25, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akalenyu akalenyu

@oshoval oshoval

Assignees

@mhenriks mhenriks

@alromeros alromeros

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/virtctl dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/buildsystem Denotes an issue or PR that relates to changes in the build system. sig/storage size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kubevirt-bot @alromeros @mhenriks @brianmcarey @kubevirt-commenter-bot