Cleanup owner aliases #11355
Cleanup owner aliases #11355
Conversation
kubevirt-bot
added
the
dco-signoff: yes
kubevirt-bot
added
do-not-merge/release-note-label-needed
|
@xpivarc @acardace please review cc @iholder101 fyi |
kubevirt-bot
added
release-note-none
|
cc @enp0s3 |
|
While I think that sig-compute would probably be eventually split to some sub-SIGs, I agree that it is more valuable to take the pragmatic approach of starting this process out and refine it later in the future. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iholder101 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/lgtm |
|
@fabiand: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
Required labels detected, running phase 2 presubmits: |
|
/retest |
|
/retest-required |
kubevirt-bot
added
the
needs-rebase
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
Without much thinking sig-node got introduced before. But in order to change incremenetally, we only use sig-compute by now, and the discussion about a potential split (into node and cluster) is deferred. Keeping sig-compute also helps to keep ownership of mainy tests clear. Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
fabiand
force-pushed
the
cleanup-owner-aliases
branch
from
418f3c7 to
63aeb39
Compare
kubevirt-bot
removed
lgtm
|
/retest |
|
/lgtm |
|
Required labels detected, running phase 2 presubmits: |
|
@dhiller: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-kubevirt-e2e-windows2016 |
What this PR does
Before this PR: We had more but empty and unusued sigs
After this PR: We have less - but used and staffed - sigs
Why we need it and why it was done in this way
The following tradeoffs were made: Keep the current lis of sigs, but this would require staffing and defining ownership, which is tricky, thus we realign on sig-compute for now
The following alternatives were considered: Keep sigs, but this would require more work to define ownership and update code, htis is too much work that we do not want right now
Links to places where the discussion took place: i.e. https://groups.google.com/g/kubevirt-dev/c/dXvwU6Pon7Y
Special notes for your reviewer
The decision about sig-node and sig-cluster/scheduling can take place separataely, but should not block this PR.
This PR reflects reality.
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note